Update knot vector synthesis for approximate_curve and approximate_surface#121
Closed
GarthSnyder wants to merge 3 commits intoorbingol:5.x-devfrom
Closed
Update knot vector synthesis for approximate_curve and approximate_surface#121GarthSnyder wants to merge 3 commits intoorbingol:5.x-devfrom
GarthSnyder wants to merge 3 commits intoorbingol:5.x-devfrom
Conversation
This was referenced Feb 5, 2021
Codecov Report
@@ Coverage Diff @@
## 5.x-dev #121 +/- ##
===========================================
+ Coverage 47.18% 47.67% +0.48%
===========================================
Files 36 36
Lines 6739 6739
Branches 1663 1663
===========================================
+ Hits 3180 3213 +33
+ Misses 3270 3236 -34
- Partials 289 290 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Author
Owner
|
Looks like this was automatically closed when I deleted the |
Author
|
Oops, sorry about that. This is now PR #187. |
Repository owner
locked and limited conversation to collaborators
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119 and #120. Includes tests to verify that knot vectors are well-formed, that every knot span includes at least one new data point, and that knot vectors generated for reversed curves are the inverses of those generated in the opposite direction.